Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: try GitHub Actions CI for running tests #29193

Closed
wants to merge 4 commits into from
Closed

build: try GitHub Actions CI for running tests #29193

wants to merge 4 commits into from

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Aug 18, 2019

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Aug 18, 2019
@targos
Copy link
Member

targos commented Aug 18, 2019

Something cancelled the build, I don't know what.

@cclauss
Copy link
Contributor Author

cclauss commented Aug 18, 2019

Seem like when one branch fails, GitHub CI fails the others.

This was referenced Aug 18, 2019
Closed
Closed
@cclauss cclauss added the python PRs and issues that require attention from people who are familiar with Python. label Aug 19, 2019
@targos
Copy link
Member

targos commented Aug 20, 2019

@cclauss I found there is an option to prevent cancelling the matrix if one job fails:
https://help.github.com/en/articles/workflow-syntax-for-github-actions#jobsjob_idstrategyfail-fast

@cclauss
Copy link
Contributor Author

cclauss commented Aug 20, 2019

Nice! I also found and added continue-on-error at the job level which is analogous to Travis CI's allow_failures. Nice collaboration among Team Switzerland...

@cclauss
Copy link
Contributor Author

cclauss commented Aug 20, 2019

Can someone with Travis CI admin rights please rerun Travis CI - Pull Request?

@Trott
Copy link
Member

Trott commented Aug 20, 2019

Can someone with Travis CI admin rights please rerun Travis CI - Pull Request?

There's a Re-Run button but it's not working for me. If all else fails, one thing you can do to get a re-run is force-push to the branch after a basically-no-op rebase.

@trivikr trivikr mentioned this pull request Aug 20, 2019
Closed
@Trott
Copy link
Member

Trott commented Aug 23, 2019

@cclauss Is this an experiment for now or are you hoping to land this? If the latter, let's ping for some reviews. (And if it should be closed, obviously let's do that.)

@cclauss
Copy link
Contributor Author

cclauss commented Aug 26, 2019 •
edited
Loading

I would be interested to replace Travis CI with GitHub Actions-based CI however GitHub Actions remains in Beta until November. We can close this PR now and create a new one once GitHub Actions goes GA. Thanks to @targos for the investigation.

@cclauss cclauss closed this Aug 26, 2019
@cclauss cclauss deleted the GitHub-Actions-CI branch August 26, 2019 10:31
@trivikr trivikr mentioned this pull request Aug 26, 2019
Closed
@cclauss cclauss mentioned this pull request Sep 9, 2019
Merged
@trivikr trivikr mentioned this pull request Sep 30, 2019
Closed
@mscdex mscdex mentioned this pull request Dec 18, 2019
Closed
@cclauss cclauss restored the GitHub-Actions-CI branch December 19, 2019 14:10
@cclauss cclauss reopened this Dec 19, 2019
@cclauss @BridgeAR
Update .github/workflows/pythonpackage.yml
f6d2ae1 
Co-Authored-By: Ruben Bridgewater <ruben@bridgewater.de>
richardlau
richardlau reviewed Dec 19, 2019
View reviewed changes
.github/workflows/pythonpackage.yml
run: |
make lint
- name: make test
continue-on-error: true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that Node.js should build with Python 3 is continue-on-error desired?

@gengjiawen
Copy link
Member

Since #29474 involved test, I think maybe we can drop this PR ?

@BridgeAR
Copy link
Member

This needs a rebase.

@cclauss
Copy link
Contributor Author

cclauss commented Jan 12, 2020

No longer needed sonce #29474 involved similar tests

@cclauss cclauss closed this Jan 12, 2020
@cclauss cclauss deleted the GitHub-Actions-CI branch January 12, 2020 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR left review comments

@richardlau richardlau richardlau left review comments

Assignees
No one assigned
Labels
meta Issues and PRs related to the general management of the project. python PRs and issues that require attention from people who are familiar with Python.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@cclauss @targos @Trott @gengjiawen @BridgeAR @richardlau @nodejs-github-bot